Hi Köry, I love your patch! Perhaps something to improve: [auto build test WARNING on v6.2] [also build test WARNING on next-20230303] [cannot apply to net/master net-next/master horms-ipvs/master linus/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/K-ry-Maincent/net-ethtool-Refactor-identical-get_ts_info-implementations/20230304-004527 patch link: https://lore.kernel.org/r/20230303164248.499286-3-kory.maincent%40bootlin.com patch subject: [PATCH v2 2/4] net: Expose available time stamping layers to user space. config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230304/202303040133.slT4slaW-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/90d54e1c6ed12a0b55c868e7808d93f61dad3534 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review K-ry-Maincent/net-ethtool-Refactor-identical-get_ts_info-implementations/20230304-004527 git checkout 90d54e1c6ed12a0b55c868e7808d93f61dad3534 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/core/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303040133.slT4slaW-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): net/core/net-sysfs.c: In function 'available_timestamping_providers_show': >> net/core/net-sysfs.c:627:35: warning: variable 'ops' set but not used [-Wunused-but-set-variable] 627 | const struct ethtool_ops *ops; | ^~~ net/core/net-sysfs.c: In function 'current_timestamping_provider_show': net/core/net-sysfs.c:657:35: warning: variable 'ops' set but not used [-Wunused-but-set-variable] 657 | const struct ethtool_ops *ops; | ^~~ vim +/ops +627 net/core/net-sysfs.c 622 623 static ssize_t available_timestamping_providers_show(struct device *dev, 624 struct device_attribute *attr, 625 char *buf) 626 { > 627 const struct ethtool_ops *ops; 628 struct net_device *netdev; 629 struct phy_device *phydev; 630 int ret = 0; 631 632 netdev = to_net_dev(dev); 633 phydev = netdev->phydev; 634 ops = netdev->ethtool_ops; 635 636 if (!rtnl_trylock()) 637 return restart_syscall(); 638 639 ret += sprintf(buf, "%s\n", "mac"); 640 buf += 4; 641 642 if (phy_has_tsinfo(phydev)) { 643 ret += sprintf(buf, "%s\n", "phy"); 644 buf += 4; 645 } 646 647 rtnl_unlock(); 648 649 return ret; 650 } 651 static DEVICE_ATTR_RO(available_timestamping_providers); 652 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
