On Fri, Aug 07, 2009 at 08:56:06PM +0530, Anuj Aggarwal wrote: > Adding support for TI TPS6507x regulator driver Exactly which chips does this driver support? Google tells me that at least some of the parts in the TPS6507x range have functionality other than regulator support on them like power path management and touch which would mean that the drivers should be using the MFD framework to hook in to the various subsystems unless the device presents as multiple devices on the I2C bus. Otherwise my comments here are essentially the same as for the previous driver - it looks good but the same relatively minor issues apply. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html