On Fri, Aug 07, 2009 at 08:55:36PM +0530, Anuj Aggarwal wrote: This is OK but since you'll need to resubmit anyway it might be nice to consider moving the register & bitfield definitions into the driver file since they can't be used by any other code. > +/* DCDC's */ Extra ' here :) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html