Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/10/2022 04:39, jerome Neanne wrote:
>> You explained what you did, which is easily visible. You did not explain
>> why you are doing it.
>>
>> Best regards,
>> Krzysztof
>>
> Thanks for pointing me to the detailed guidelines
> I'm new to upstream and not well aware of all good practices.
> 
> Would below commit message be more suitable:
> 
> Add support for the TPS65219 PMIC by enabling MFD, regulator and 
> power-button drivers.  All drivers enabled as modules.

This still says only what you did. I still does not explain why.

Best regards,
Krzysztof




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux