On 12/10/2022 04:39, jerome Neanne wrote: >> You explained what you did, which is easily visible. You did not explain >> why you are doing it. >> >> Best regards, >> Krzysztof >> > Thanks for pointing me to the detailed guidelines > I'm new to upstream and not well aware of all good practices. > > Would below commit message be more suitable: > > Add support for the TPS65219 PMIC by enabling MFD, regulator and > power-button drivers. All drivers enabled as modules. This still says only what you did. I still does not explain why. Best regards, Krzysztof
