Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/10/2022 16:48, Krzysztof Kozlowski wrote:
On 11/10/2022 10:05, Jerome Neanne wrote:
This adds defconfig option to support TPS65219 PMIC, MFD, Regulators

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

and power-button.

You explained what you did, which is easily visible. You did not explain
why you are doing it.

Best regards,
Krzysztof

Thanks for pointing me to the detailed guidelines
I'm new to upstream and not well aware of all good practices.

Would below commit message be more suitable:

Add support for the TPS65219 PMIC by enabling MFD, regulator and power-button drivers. All drivers enabled as modules.

Best regards
Jerome



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux