At 2022-06-28 12:57:12, "Tony Lindgren" <tony@xxxxxxxxxxx> wrote: >Hi, > >* Liang He <windhl@xxxxxxx> [220618 04:43]: >> In _init(), of_find_node_by_name() will return a node pointer with >> refcount incremented. We should use of_node_put() in fail path or >> when it is not used anymore. >> >> NOTE: As the ref will be passed from 'bus' to 'np' by the xx_lookup(), >> in normal exit path, we should call of_node_put() at the end use of 'np', >> not the end use of 'bus'. > >Looks correct to me. What about missing of_node_put() for >of_get_next_child() also in the _init() function? > >Regards, > >Tony Thanks, Tony. I have found this bug but not send the patch for of_get_next_child() as I am collecting other OF function related bugs and I have been told that it is better to collect all similar bugs in same directory, then finally report them. So I will send a new patch for both of the two missing 'put' bugs caused by of_find_xxx() and of_get_xxx() in omap_hwmod.c Thanks gain. Liang
