On Thu, 13 Jan 2022, Uwe Kleine-König wrote: > If twl4030_exit_irq() returns an error, the effect is that the caller > (twl_remove()) forwards the error to the i2c core without unregistering > its dummy slave devices. This only makes the i2c core emit another > error message and then it still removes the device. > > In this situation it doesn't make sense to abort the remove cleanup and not > unregister the slave devices. So do that. Then return value is actually > unused and twl4030_exit_irq() can better be changed to return no value at > all. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/mfd/twl-core.c | 6 +----- > drivers/mfd/twl-core.h | 2 +- > drivers/mfd/twl4030-irq.c | 7 ++----- > 3 files changed, 4 insertions(+), 11 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
