On Wed, Jun 23, 2021 at 08:27:51PM -0700, 13145886936@xxxxxxx wrote:
> From: gushengxian <gushengxian@xxxxxxxxxx>
>
> Remove unneeded variable: "errata".
>
> Signed-off-by: gushengxian <gushengxian@xxxxxxxxxx>
NAK.
> diff --git a/arch/arm/mach-omap2/dma.c b/arch/arm/mach-omap2/dma.c
> index dfc9b21ff19b..ba4a48e3d264 100644
> --- a/arch/arm/mach-omap2/dma.c
> +++ b/arch/arm/mach-omap2/dma.c
> @@ -79,7 +79,6 @@ static const struct omap_dma_reg reg_map[] = {
>
> static unsigned configure_dma_errata(void)
> {
> - unsigned errata = 0;
>
> /*
> * Errata applicable for OMAP2430ES1.0 and all omap2420
> @@ -158,7 +157,7 @@ static unsigned configure_dma_errata(void)
> if (cpu_is_omap34xx() && (omap_type() != OMAP2_DEVICE_TYPE_GP))
> SET_DMA_ERRATA(DMA_ROMCODE_BUG);
>
> - return errata;
> + return 0;
It is _not_ "unneeded" and you clearly have not compiled the resulting
code from your patch.
#define SET_DMA_ERRATA(id) (errata |= (id))
errata is used inside the SET_DMA_ERRATA() macro. Hence, building
mach-omap2/dma.c would have failed.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
