Re: Regression with 6cfcd5563b4f on BeagleBoard Rev C2

[Tony Lindgren <tony@xxxxxxxxxxx>]

Hi,

* Jarkko Nikula <jarkko.nikula@xxxxxxxxxx> [210602 18:21]:
> Hi
> 
> On 6/2/21 8:30 AM, Tony Lindgren wrote:
> > Sounds like the beagleboard timer errata handling is either picking
> > a wrong clockevent timer, or later on ti-sysc misdetects the active
> > timer for clockevent and idles it.
> > 
> > What does dmesg say in the beginning for clockevent and clocksource
> > timers?
> > 
> I attached logs from commit 6cfcd5563b4f and commit 30c66fc30ee7 before
> it. Perhaps this is relevant difference between them?
> 
> +ti-sysc: probe of 49032000.target-module failed with error -16
> +ti-sysc: probe of 48304000.target-module failed with error -16

Yeah so it seems. We now attempt to ignore the system timer instances
while it seems we need also block idling at least for timer12 that is
used for the beagle timer.

Can you test the following patch and see if it helps?

Regards,

Tony

8< ------------------------
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -100,6 +100,7 @@ static const char * const clock_names[SYSC_MAX_CLOCKS] = {
  * @cookie: data used by legacy platform callbacks
  * @name: name if available
  * @revision: interconnect target module revision
+ * @reserved: target module is reserved and already in use
  * @enabled: sysc runtime enabled status
  * @needs_resume: runtime resume needed on resume from suspend
  * @child_needs_resume: runtime resume needed for child on resume from suspend
@@ -130,6 +131,7 @@ struct sysc {
 	struct ti_sysc_cookie cookie;
 	const char *name;
 	u32 revision;
+	unsigned int reserved:1;
 	unsigned int enabled:1;
 	unsigned int needs_resume:1;
 	unsigned int child_needs_resume:1;
@@ -3045,8 +3047,8 @@ static int sysc_probe(struct platform_device *pdev)
 		return error;
 
 	error = sysc_check_active_timer(ddata);
-	if (error)
-		return error;
+	if (error == -EBUSY)
+		ddata->reserved = true;
 
 	error = sysc_get_clocks(ddata);
 	if (error)
@@ -3082,11 +3084,15 @@ static int sysc_probe(struct platform_device *pdev)
 	sysc_show_registers(ddata);
 
 	ddata->dev->type = &sysc_device_type;
-	error = of_platform_populate(ddata->dev->of_node, sysc_match_table,
-				     pdata ? pdata->auxdata : NULL,
-				     ddata->dev);
-	if (error)
-		goto err;
+
+	if (!ddata->reserved) {
+		error = of_platform_populate(ddata->dev->of_node,
+					     sysc_match_table,
+					     pdata ? pdata->auxdata : NULL,
+					     ddata->dev);
+		if (error)
+			goto err;
+	}
 
 	INIT_DELAYED_WORK(&ddata->idle_work, ti_sysc_idle);