From: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> Subject: Re: [PATCH 1/1] DSPBRIDGE: expose DSP_TRACEBUF as kernel config option Date: Sat, 25 Jul 2009 08:23:59 +0300 (EEST) > From: "ext Kanigeri, Hari" <h-kanigeri2@xxxxxx> > Subject: RE: [PATCH 1/1] DSPBRIDGE: expose DSP_TRACEBUF as kernel config option > Date: Sat, 25 Jul 2009 02:43:41 +0200 > > > Hiroshi, > > > > > The problem here is that now all TRACEBUF code is always compiled in > > > in spite of setting "DEBUG". It doesn't print anything, but just > > > wastes some memory > > > > That's not true. DSP_TRACEBUF is used to print the traces from DSP. This is used by Socket node developers to print their traces from DSP to console. > > If you enable DT=1 GT trace, then you get all the prints from DSP, which is extremely useful for DSP Developers. > > I understand that DSP_TRACEBUF is useful. But now DSP_TRACEBUF is > always complied in and it cannot print anything without defining > GT_TRACE, IOW, without defining CONFIG_DSP_DEBUG. This is the matter of > dependency of those DEFINEs, DSP_TRACEBUF and DEBUG. Kconfig can describe > those dependency. I am proposing to set the dependency of DSP_TRACEBUF > on CONFIG_DSP_DEBUG, to save some memory instead of keeping unused > code(ex: PrintDSPDebugTrace()) in this driver. And here's the revised version of patch attached.
Attachment:
0001-DSPBRIDGE-Set-dependency-of-DSP_TRACEBUF-on-DSP_DEB.patch
Description: Binary data
