Hiroshi, > The problem here is that now all TRACEBUF code is always compiled in > in spite of setting "DEBUG". It doesn't print anything, but just > wastes some memory That's not true. DSP_TRACEBUF is used to print the traces from DSP. This is used by Socket node developers to print their traces from DSP to console. If you enable DT=1 GT trace, then you get all the prints from DSP, which is extremely useful for DSP Developers. Thank you, Best regards, Hari > -----Original Message----- > From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx] > Sent: Friday, July 24, 2009 1:00 PM > To: Kanigeri, Hari > Cc: linux-omap@xxxxxxxxxxxxxxx; ameya.palande@xxxxxxxxx; Guzman Lugo, > Fernando; Ramirez Luna, Omar > Subject: Re: [PATCH 1/1] DSPBRIDGE: expose DSP_TRACEBUF as kernel config > option > > Hi Hari, > > From: "ext Kanigeri, Hari" <h-kanigeri2@xxxxxx> > Subject: RE: [PATCH 1/1] DSPBRIDGE: expose DSP_TRACEBUF as kernel config > option > Date: Fri, 24 Jul 2009 19:28:47 +0200 > > > Hi Doyu-san, > > > > > > > > "CONFIG_DSP_TRACEBUF" is introduced as a kernel config option to save > > > some amount of unused memory and "#ifndef DSP_TRACEBUF_DISABLED" was > > > not easy to understand. > > > > > > > I think we just use the Bridge DEBUG flag that is used in Bridge instead > of introducing a new flag. > > It might be better if "CONFIG_DSP_TRACEBUF" had the dependecy on > "DEBUG/CONFIG_BRIDGE_DEBUG", but it's not unfortunately. > > The problem here is that now all TRACEBUF code is always compiled in > in spite of setting "DEBUG". It doesn't print anything, but just > wastes some memory. > > I'll remove a new Kconfig entry and just add the dependency of > "CONFIG_DSP_TRACEBUF" on "CONFIG_BRIDGE_DEBUG". -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
