Hi Amit, On Wed, Jul 22, 2009 at 7:55 PM, Amit Kucheria<amit.kucheria@xxxxxxxxxxxxx> wrote: > On 09 Jul 20, Trilok Soni wrote: >> Hi Vikram, >> >> > + >> > +#include <linux/kernel.h> >> > +#include <linux/module.h> >> > +#include <linux/init.h> >> > +#include <linux/interrupt.h> >> > +#include <linux/input.h> >> > +#include <linux/platform_device.h> >> > +#include <linux/i2c/twl4030.h> >> > +#include <mach/keypad.h> >> >> One empty line between above two headers. >> >> I hope you are aware of earlier comments posted for this driver when >> it was submitted few months back and had long discussion on threaded >> irq stuff. >> > > Trilok, > > Could you please post a link to that discussion. Google isn't pointing > me to any relevant discussions besides > http://lkml.org/lkml/2008/10/1/334 > > I'll do a further cleanup and resubmit. If you follow latest discussion as below, you will get the pointers. http://marc.info/?l=linux-i2c&m=124828117611346&w=2 It is also CCed to linux-input as well. -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
