On 09 Jul 20, Trilok Soni wrote: > Hi Vikram, > > > + > > +#include <linux/kernel.h> > > +#include <linux/module.h> > > +#include <linux/init.h> > > +#include <linux/interrupt.h> > > +#include <linux/input.h> > > +#include <linux/platform_device.h> > > +#include <linux/i2c/twl4030.h> > > +#include <mach/keypad.h> > > One empty line between above two headers. > > I hope you are aware of earlier comments posted for this driver when > it was submitted few months back and had long discussion on threaded > irq stuff. > Trilok, Could you please post a link to that discussion. Google isn't pointing me to any relevant discussions besides http://lkml.org/lkml/2008/10/1/334 I'll do a further cleanup and resubmit. Regards, Amit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html