On 01/12/2020 02:31, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thank you for the patch.
>
> On Tue, Nov 24, 2020 at 02:45:29PM +0200, Tomi Valkeinen wrote:
>> Move structs and defines to a private dsi.h header file to make dsi.c a
>> bit easier to navigate. Also move the (now) private structs and defines
>> from omapdss.h to dsi.h.
>
> I usually tend to keep structures used by a single .c file in that file,
> but it's a matter of personal preference I suppose.
We already had dsi.h. After all the recent changes, it was now only used by dsi.c. So I could have
moved everything from there to dsi.c. But dsi.c was pretty crowded already, and I had trouble
navigating it, so I thought it's better to move structs and macros from dsi.c to dsi.h.
>> +struct dsi_reg { u16 module; u16 idx; };
>
> How about using the common kernel coding style ?
>
> struct dsi_reg {
> u16 module;
> u16 idx;
> };
Ok.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
