On 01/12/2020 02:27, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Nov 24, 2020 at 02:45:28PM +0200, Tomi Valkeinen wrote: >> Drop unneeded includes. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> >> --- >> drivers/gpu/drm/panel/panel-dsi-cm.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c >> index ec87b785871f..91ed8237a1c2 100644 >> --- a/drivers/gpu/drm/panel/panel-dsi-cm.c >> +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c >> @@ -9,12 +9,7 @@ >> #include <linux/backlight.h> >> #include <linux/delay.h> >> #include <linux/gpio/consumer.h> >> -#include <linux/interrupt.h> > > This could go to the patch that moves TE handling to the code. True. >> #include <linux/jiffies.h> >> -#include <linux/module.h> > > I'd keep module.h as you use macros it defines, and we shouldn't depend > in indirect includes. Ok. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki