On 14.10.2020 17.52, Thomas Gleixner wrote: > From: Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx> > > The usage of in_interrupt() in drivers is phased out for various reasons. > > xhci_set_hc_event_deq() has an !in_interrupt() check which is pointless > because the function is only invoked from xhci_mem_init() which is clearly > task context as it does GFP_KERNEL allocations. Remove it. > > xhci_urb_enqueue() prints a debug message if an URB is submitted after the > underlying hardware was suspended. But that warning is only issued when > in_interrupt() is true, which makes no sense. Simply return -ESHUTDOWN and > be done with it. > > Signed-off-by: Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Mathias Nyman <mathias.nyman@xxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: linux-usb@xxxxxxxxxxxxxxx > --- > drivers/usb/host/xhci-mem.c | 2 +- > drivers/usb/host/xhci.c | 6 ++---- > 2 files changed, 3 insertions(+), 5 deletions(-) Acked-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
