On 7/10/20 1:29 PM, Suman Anna wrote:
On 7/10/20 12:59 PM, Tony Lindgren wrote:
* Suman Anna <s-anna@xxxxxx> [200710 17:29]:
FYI, the following one-line removal is enough for me to not see the
error.
diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
index 86f1ac4c2412..b80c9dff81c4 100644
--- a/arch/arm/mach-omap2/vc.c
+++ b/arch/arm/mach-omap2/vc.c
@@ -44,7 +44,6 @@
#define OMAP4_VDD_DEFAULT_VAL \
(OMAP4430_VDD_I2C_DISABLE_MASK | \
OMAP4430_VDD_IVA_PRESENCE | OMAP4430_VDD_MPU_PRESENCE | \
- OMAP4430_AUTO_CTRL_VDD_IVA(OMAP4430_AUTO_CTRL_VDD_RET) | \
OMAP4430_AUTO_CTRL_VDD_MPU(OMAP4430_AUTO_CTRL_VDD_RET) | \
OMAP4430_AUTO_CTRL_VDD_CORE(OMAP4430_AUTO_CTRL_VDD_RET))
OK.
Below is an untested attempt to sync the 4460 opp values with
what earlier TI kernels had. Not sure if this help, might be worth
testing :) My pandaboard-es seems to have a corrupt sdio card.
Yeah, mine is the regular pandaboard with 4430, so the below patch will
not make any difference.
regards
Suman
Regards,
Tony
8< ---------------------
diff --git a/arch/arm/mach-omap2/opp4xxx_data.c
b/arch/arm/mach-omap2/opp4xxx_data.c
--- a/arch/arm/mach-omap2/opp4xxx_data.c
+++ b/arch/arm/mach-omap2/opp4xxx_data.c
@@ -66,21 +66,23 @@ struct omap_volt_data
omap443x_vdd_core_volt_data[] = {
};
#define OMAP4460_VDD_MPU_OPP50_UV 1025000
-#define OMAP4460_VDD_MPU_OPP100_UV 1200000
-#define OMAP4460_VDD_MPU_OPPTURBO_UV 1313000
-#define OMAP4460_VDD_MPU_OPPNITRO_UV 1375000
+#define OMAP4460_VDD_MPU_OPP100_UV 1203000
+#define OMAP4460_VDD_MPU_OPPTURBO_UV 1317000
+#define OMAP4460_VDD_MPU_OPPNITRO_UV 1380000
+#define OMAP4460_VDD_MPU_OPPNITROSB_UV 1390000
I am not sure about this, I see it as 1380 for both OPPNITRO and OPPNITROSB.
struct omap_volt_data omap446x_vdd_mpu_volt_data[] = {
VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPP50_UV,
OMAP44XX_CONTROL_FUSE_MPU_OPP50, 0xf4, 0x0c),
VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPP100_UV,
OMAP44XX_CONTROL_FUSE_MPU_OPP100, 0xf9, 0x16),
VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPPTURBO_UV,
OMAP44XX_CONTROL_FUSE_MPU_OPPTURBO, 0xfa, 0x23),
VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPPNITRO_UV,
OMAP44XX_CONTROL_FUSE_MPU_OPPNITRO, 0xfa, 0x27),
+ VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPPNITROSB_UV,
OMAP44XX_CONTROL_FUSE_MPU_OPPNITROSB, 0xfa, 0x27),
VOLT_DATA_DEFINE(0, 0, 0, 0),
};
-#define OMAP4460_VDD_IVA_OPP50_UV 1025000
-#define OMAP4460_VDD_IVA_OPP100_UV 1200000
-#define OMAP4460_VDD_IVA_OPPTURBO_UV 1313000
+#define OMAP4460_VDD_IVA_OPP50_UV 950000
+#define OMAP4460_VDD_IVA_OPP100_UV 1140000
Btw, this should be 1114000
+#define OMAP4460_VDD_IVA_OPPTURBO_UV 1291000
#define OMAP4460_VDD_IVA_OPPNITRO_UV 1375000
struct omap_volt_data omap446x_vdd_iva_volt_data[] = {
@@ -91,8 +93,8 @@ struct omap_volt_data omap446x_vdd_iva_volt_data[] = {
VOLT_DATA_DEFINE(0, 0, 0, 0),
};
-#define OMAP4460_VDD_CORE_OPP50_UV 1025000
-#define OMAP4460_VDD_CORE_OPP100_UV 1200000
+#define OMAP4460_VDD_CORE_OPP50_UV 962000
+#define OMAP4460_VDD_CORE_OPP100_UV 1127000
#define OMAP4460_VDD_CORE_OPP100_OV_UV 1250000
struct omap_volt_data omap446x_vdd_core_volt_data[] = {
Atleast this update and the previous OMAP4430 patch matches up to what I
can see from the Data Manual. So, guess you can add an official version
of this patch.
regards
Suman
