On Mon, Jul 06, 2009 at 11:50:59AM +0200, Balbi Felipe (Nokia-D/Helsinki) wrote: > Hi, > > On Mon, Jul 06, 2009 at 10:55:05AM +0200, ext Gupta, Ajay Kumar wrote: > > Looks better but if USB itself is not included in the build then this part of code would be unnecessary in board-omap3evm.c. We again need to add some #ifdef there to avoid this. > > > > Another solution is to add something like board_is_omap3evm() in <mach/board.h> and use them in usb-ehci.c. > > > > Felipe, what do you suggest? > > how about passing setup() and cleanup() function pointers from > board-file to the driver via platform_data ? > > the board-specific setup() could handle the mux config then. looking more closely, it doesn't make sense what I said... I need to think this through a little bit more, but I guess, for now the ifdef is the way to go to, at least, get the board working. I'll think this through. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
