> >
> > +#ifdef CONFIG_MACH_OMAP3EVM
> > + /* Setup phy reset pin for EHCI on OMAP3EVM */
> > + omap_cfg_reg(AF4_34XX_GPIO135_OUT);
> > +#endif
> Why don't put this into board-omap3evm.c?
>
> For example, on beagle the phy reset signal is routed to GPIO147. I
> don't think we want to see several "#ifdef CONFIG_MACH_..." here.
Looks better but if USB itself is not included in the build then this part of code would be unnecessary in board-omap3evm.c. We again need to add some #ifdef there to avoid this.
Another solution is to add something like board_is_omap3evm() in <mach/board.h> and use them in usb-ehci.c.
Felipe, what do you suggest?
>
> Moreover, that setup_ehci_io_mux() function is also board-specific since
> different boards may use different pinmux settings or different USB
> ports may be enabled/disabled there. Well, at least the function should
> allow to configure only required USB ports.
This is coming very soon.
-Ajay
>
>
> Dmitry
> > if (platform_device_register(&ehci_device) < 0) {
> > printk(KERN_ERR "Unable to register HS-USB (EHCI) device\n");
> > return;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
