Hi! > Don't report that the battery is fully charged if the charging current > exceeds 100 mA. Could you merge patches together for possibility of reasonable review? > @@ -408,7 +408,8 @@ static bool cpcap_battery_full(struct cpcap_battery_ddata *ddata) > struct cpcap_battery_state_data *state = cpcap_battery_latest(ddata); > > if (state->voltage >= > - (ddata->config.bat.constant_charge_voltage_max_uv - 18000)) > + (ddata->config.bat.constant_charge_voltage_max_uv - 18000) && > + state->current_ua > -100000) It seems that this 100mA threshold is changed about 3 times in the series :-(. Plus, it might be better to place booleans into struct, rather than using "static bool" inside a function. Could we get some kind of explanations for the whole series? 100mA is rather high current for end of charge. If you stop updating full capacity when "your" end of charge is met, you'll have battery charged to more than 100%. I... don't think that makes sense. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
