> -----Original Message----- > From: Mike Chan [mailto:mike@xxxxxxxxxxx] > Sent: 2009年6月25日 9:25 > To: Wang Sawsd-A24013 > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] Support OMAP3 VC adaptation with > different Power IC > > Wang Sawsd-A24013 wrote: > > From c1aba8ba7af3ddd16346d95795bda71e65baa4d0 Mon Sep 17 > 00:00:00 2001 > > From: Chunqiu Wang <cqwang@xxxxxxxxxxxx> > > Date: Wed, 24 Jun 2009 06:48:52 +0800 > > Subject: [PATCH] Support OMAP3 VC adaptation with different Power IC > > > > Current OMAP SmartReflex driver only supports TI Triton > > Power IC, add a callback to make it possible to use > > different PowerIC and use different settings to > > configure OMAP3 Voltage Controller for DVFS > > > > Board file can setup a new function to have different settings > > on SR to configure their Power IC for voltage scaling > > > > Signed-off-by: Chunqiu Wang <cqwang@xxxxxxxxxxxx> > > --- > > arch/arm/mach-omap2/smartreflex.c | 13 +++++++++++++ > > arch/arm/mach-omap2/smartreflex.h | 4 ++++ > > arch/arm/plat-omap/Kconfig | 2 +- > > 3 files changed, 18 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/smartreflex.c > > b/arch/arm/mach-omap2/smartreflex.c > > index 9d462e3..bacf602 100644 > > --- a/arch/arm/mach-omap2/smartreflex.c > > +++ b/arch/arm/mach-omap2/smartreflex.c > > @@ -52,6 +52,8 @@ struct omap_sr { > > > > #define SR_REGADDR(offs) (sr->srbase_addr + offset) > > > > +static omap3_voltagescale_vcbypass_t omap3_volscale_vcbypass_fun; > > > Perhaps use > static int (*omap3_volscale_vcbypass_fun) (u32, u32, u8, u8); > > This gets rid of the compiler warning on incompatible pointer > types when > you register a function via omap3_voltagescale_vcbypass_setup(). > > -- Mike Thanks Mike, but we do not see the warnning with the original Code, note this patch is slightly different with the one we sent To you based on K29, this new patch have four parameters Sinc some change has been made in the sr_voltagescale_vcbypass to add two more parameters. Is your warnning caused by this? Thanks, Chunqiu -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
