On Wed, Oct 9, 2019 at 3:13 PM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > * Adam Ford <aford173@xxxxxxxxx> [191009 18:56]: > > On Wed, Sep 25, 2019 at 12:14 PM Adam Ford <aford173@xxxxxxxxx> wrote: > > > > > > The AES and SHA engines for the OMAP3 are currently not functional. > > > When the stopped working is unknown, but we have a regression. > > > > > > This patch uses the ti,sysc-omap2 to address the issue and enables > > > to the AES and SHA engines on the DM3730 and OMAP3530 to work once > > > again. > > > > > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > > > Tony, > > > > Any chance these could get review and/or pushed for 5.4 since they > > used to work and now they don't. I didn't do a bisect, so I didn't > > add a 'fixes' note, but this patch seems to fix a regression. > > Well let's rather tag them with fixes tag and that way they get > merged to stable kernels when ready. > > I'd rather not hastily start adding devices hastily during the -rc > cycle as by the time we get there with few weeks in next we're > already too close to the merge window. > > And my guess is that this stuff has been broken for many years > and nobody cared until now. I will try to bisect it tomorrow. > > A fixes tag would be good to know though.. And maybe we can get them > working with hwmod data for v5.4-rc cycle with just a minimal change? That would be nice. I am mostly interested because the last kernel Logic PD released (4.9) had it working and I am hoping to minimize the patching I will have to do to the 5.4 kernel when done. thanks, adam > > Regards, > > Tony