On 09/04/19 9:29 AM, Keerthy wrote:
On 08/04/19 11:13 PM, Tony Lindgren wrote:
* Tony Lindgren <tony@xxxxxxxxxxx> [190408 10:26]:
* Keerthy <j-keerthy@xxxxxx> [190402 21:57]:
Changes in v3:
* Exported out omap_rtc_poweroff_program function & removed
the patch to add a generic rtc interface as it is specific
to am43 at the moment.
Thanks I'll be applying this series into omap-for-v5.2/am4-pm
today.
Sorry correction for the branch named above. I noticed a build
warning and folded in the following fix. We need to return
-EINVAL if tm2bcd() fails like we do elsewhere in the driver.
So I just pushed out a new branch omap-for-v5.2/am4-pm-v2.
Please just ignore the earlier branch omap-for-v5.2/am4-pm.
Thanks Tony!
Tony,
Seems like your for-next is a little behind. Hence you noticed the
compilation error which i did not notice. The rtc driver patch i
formatted from your for-next branch does not apply cleanly on linux-next
as there are more patches already applied by Alexandre on next.
So the patch you made to return -EINVAL is no longer needed on latest next.
Thanks,
Keerthy
Regards,
Tony
8< --------------------
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc/rtc-omap.c
@@ -447,7 +447,7 @@ int omap_rtc_power_off_program(struct device *dev)
if (tm2bcd(&tm) < 0) {
dev_err(&rtc->rtc->dev, "power off failed\n");
rtc->type->lock(rtc);
- return;
+ return -EINVAL;
}
rtc_wait_not_busy(rtc);
