>-----Original Message----- >From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx] >Sent: Friday, June 12, 2009 2:02 PM >To: Pandita, Vikram >Cc: Menon, Nishanth; Balbi Felipe (Nokia-D/Helsinki); linux-omap@xxxxxxxxxxxxxxx >Subject: Re: [PATCH 1/2] Serial: Define IRQ flags for 8250 driver > >On Fri, Jun 12, 2009 at 04:50:09PM +0200, ext Pandita, Vikram wrote: >> >> > >remove the default part: > >switch (up->port.flags & UPF_IRQ_FLAGS_MASK) { >case UPF_IRQ_TRIG_RISING: > irq_flags |= IRQF_TRIGGER_RISING; > break; >case UPF_IRQ_TRIG_FALLING: > irq_flags |= IRQF_TRIGGER_FALLING; > break; >case UPF_IRQ_TRIG_HIGH: > irq_flags |= IRQF_TRIGGER_HIGH; > break; >case UPF_IRQ_TRIG_LOW: > irq_flags |= IRQF_TRIGGER_LOW; > break; >default: > break; >} Have posted the original patch to linux-serial already. I can see your change is a replacement for if:else with switch:case Thanks for the review. Lets see what's the response on the patch, and see when we can put these changes in. > >-- >balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
