Hi Tony, On Thursday, 1 November 2018 18:17:43 EET Laurent Pinchart wrote: > On Thursday, 1 November 2018 17:58:56 EET Tony Lindgren wrote: > > * Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [181101 12:13]: > >> On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote: > >>> We do dispc_runtime_get/put in the HDMI driver's suspend/resume too, > >>> so don't we need similar hack (as you add in dsi.c) there also? > >> > >> We would if we had to access HDMI registers at probe time. > > > > With these I'm still seeing the following issue with hdmi on rmmod > > of omapdrm related modules as hdmi->dss is NULL in hdmi_runtime_resume. > > This is actually what I expected, but to my surprise the problem didn't > occur on my system, I don't know why. I'll try to investigate. I've submitted a v2 which should hopefully fix this. -- Regards, Laurent Pinchart