Re: [PATCH 0/3] omapdrm: Fix runtime PM issues at module load and unload time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tony,

On Thursday, 1 November 2018 17:58:56 EET Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [181101 12:13]:
> > On Thursday, 1 November 2018 13:47:40 EET Tomi Valkeinen wrote:
> > > We do dispc_runtime_get/put in the HDMI driver's suspend/resume too, so
> > > don't we need similar hack (as you add in dsi.c) there also?
> > 
> > We would if we had to access HDMI registers at probe time.
> 
> With these I'm still seeing the following issue with hdmi on rmmod
> of omapdrm related modules as hdmi->dss is NULL in hdmi_runtime_resume.

This is actually what I expected, but to my surprise the problem didn't occur 
on my system, I don't know why. I'll try to investigate.

> Regards,
> 
> Tony
> 
> 8< ------
> Unable to handle kernel NULL pointer dereference at virtual address 00000278
> ...
> PC is at hdmi_runtime_resume+0xc/0x1c [omapdss]
> LR is at __rpm_callback+0x144/0x1d8
> ...
> (hdmi_runtime_resume [omapdss]) from [<c06079b4>]
> (__rpm_callback+0x144/0x1d8) (__rpm_callback) from [<c0607a68>]
> (rpm_callback+0x20/0x80)
> (rpm_callback) from [<c06075f0>] (rpm_resume+0x60c/0x828)
> (rpm_resume) from [<c0607858>] (__pm_runtime_resume+0x4c/0x64)
> (__pm_runtime_resume) from [<c05fc7ec>]
> (device_release_driver_internal+0x130/0x234)
> (device_release_driver_internal) from [<c05fc934>]
> (driver_detach+0x38/0x6c) (driver_detach) from [<c05fb698>]
> (bus_remove_driver+0x4c/0xa4)
> (bus_remove_driver) from [<c05fe23c>]
> (platform_unregister_drivers+0x20/0x2c) (platform_unregister_drivers) from
> [<c01f0fe0>] (sys_delete_module+0x1c0/0x230) (sys_delete_module) from
> [<c0101000>] (ret_fast_syscall+0x0/0x28)

-- 
Regards,

Laurent Pinchart






[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux