On Sun, Oct 07, 2018 at 05:39:36PM +0200, Stefan Lengfeld wrote: > Using i2c_transfer() directly to set the shutdown bit is more reliable > than using regmap in atomic contexts, because calls to 'schedule()' or > 'sleep()' must be avoided in call code paths. > #include <linux/platform_device.h> > #include <linux/uaccess.h> > #include <linux/slab.h> > +#include <linux/i2c.h> > #include <linux/delay.h> > #include <linux/jiffies.h> > #include <linux/mfd/da9062/registers.h> The rule of thumb when extending a header inclusion block is that try to squeeze the new inclusion in the longest sorted part of the list. Rationale behind is easy maintenance. -- With Best Regards, Andy Shevchenko