On Sun, Oct 07, 2018 at 05:39:35PM +0200, Stefan Lengfeld wrote: > Rework the read and write code paths in the driver to support operation > in IRQ disabled contexts. The patch is currently tested only on a > phyCORE-i.MX6 Solo board. > > The driver supports normal operation, DMA transfers and now the polling > mode or also called sleep-free or IRQ-less operation. It makes the code > not simpler or easier to read, but IRQ less I2C transfers are needed on > some hardware configurations, e.g. to trigger reboots on an external > PMIC chip. > + if (!polling) > + schedule(); > + else > + udelay(100); What the point to use negative conditional when it's pretty straightforward and positive may be used? -- With Best Regards, Andy Shevchenko