RE: [PATCH] PM: Disable usb host HW save and restore

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kalle,

I just found an issue with the  pwrdm_enable_hdwr_sar function which
would actually leave the SAVEANDRESTORE bit unchanged in the PWSTCTRL
register.
http://marc.info/?l=linux-omap&m=124420689003913&w=2

The issue you were seeing with USBHOST might not really be with enabling the SAR
on USBHOST but something else.

regards,
Rajendra

>-----Original Message-----
>From: linux-omap-owner@xxxxxxxxxxxxxxx 
>[mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Kalle Jokiniemi
>Sent: Thursday, April 23, 2009 4:29 PM
>To: tony@xxxxxxxxxxx
>Cc: khilman@xxxxxxxxxxxxxxxxxxx; paul@xxxxxxxxx; 
>linux-omap@xxxxxxxxxxxxxxx; Menon, Nishanth; Woodruff, 
>Richard; Kalle Jokiniemi; Kalle Jokiniemi
>Subject: [PATCH] PM: Disable usb host HW save and restore
>
>The hardware SAVEANDRESTORE mechanism seems to leave
>USB HOST power domain permanently into active state
>after one transition from off to active state.
>Disabling for now.
>
>Signed-off-by: Kalle Jokiniemi <ext-kalle.jokiniemi@xxxxxxxxx>
>---
> arch/arm/mach-omap2/powerdomains34xx.h |    8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/powerdomains34xx.h 
>b/arch/arm/mach-omap2/powerdomains34xx.h
>index 4dcf94b..aa557b2 100644
>--- a/arch/arm/mach-omap2/powerdomains34xx.h
>+++ b/arch/arm/mach-omap2/powerdomains34xx.h
>@@ -338,7 +338,13 @@ static struct powerdomain usbhost_pwrdm = {
> 	.sleepdep_srcs	  = dss_per_usbhost_sleepdeps,
> 	.pwrsts		  = PWRSTS_OFF_RET_ON,
> 	.pwrsts_logic_ret = PWRDM_POWER_RET,
>-	.flags		  = PWRDM_HAS_HDWR_SAR, /* for USBHOST 
>ctrlr only */
>+	/*
>+	 * REVISIT: Enabling usb host save and restore 
>mechanism seems to
>+	 * leave the usb host domain permanently in ACTIVE mode after
>+	 * changing the usb host power domain state from OFF to 
>active once.
>+	 * Disabling for now.
>+	 */
>+	/*.flags	  = PWRDM_HAS_HDWR_SAR,*/ /* for 
>USBHOST ctrlr only */
> 	.banks		  = 1,
> 	.pwrsts_mem_ret	  = {
> 		[0] = PWRDM_POWER_RET, /* MEMRETSTATE */
>-- 
>1.5.4.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe 
>linux-omap" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux