Re: [RFC PATCH 1/4] i2c: allow drivers to announce that they are IRQ safe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > They are probably SMBus calls but my bet is that they will get emulated
> > to I2C transfers. SMBus controllers are more common on PC hardware and
> > above I'd say, and those seem to have so far their custom firmware
> > methods to shut down.
> 
> Right, but keep in mind that (normal) emulation will still go through
> the unconditional locking in i2c_smbus_xfer, so that will also be a
> source of problems/oopses/splats.

Damn, yes, I forgot that smbus_xfer_emulated uses the unlocked
__i2c_transfer. So, you are totally right, we need this extra dance to
handle the locking. When it comes to adding smbus_xfer_irqless, I'd
still propose to wait until we have a user for it.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux