On Fri, May 29, 2009 at 6:24 PM, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> wrote: > "Syed Rafiuddin" <rafiuddin.syed@xxxxxx> writes: >> +static int __init omap4_i2c_init(void) >> +{ >> + omap_register_i2c_bus(1, 2600, NULL, 0); why is this 2600? omap3 could do 3.3Mhz. >> + omap_register_i2c_bus(2, 400, NULL, 0); >> + omap_register_i2c_bus(3, 400, NULL, 0); >> + return 0; >> +} This code badly worries me given the omap3 story and i2c bus capacitance. The new code for omap4 should allow for scll and sclh to be board specific configurable [1] and [2] - i would expect a similar story kicking in again... Regards, Nishanth Menon Ref: [1] http://marc.info/?t=123540865900002&r=1&w=2 [2] http://marc.info/?t=123457935200001&r=1&w=2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html