On Tue, May 19, 2009 at 11:55:41AM -0700, Kevin Hilman wrote: > Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> writes: > > > On Mon, May 18, 2009 at 10:00:44AM -0700, Kevin Hilman wrote: > >> Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> writes: > >> > >> > On Fri, May 15, 2009 at 11:40:41AM -0700, Kevin Hilman wrote: > >> >> This patch is to sync the core linux-omap PM code with mainline. This > >> >> code has evolved and been used for a while the linux-omap tree, but > >> >> the attempt here is to finally get this into mainline. > >> >> > >> >> Following this will be a series of patches from the 'PM branch' of the > >> >> linux-omap tree to add full PM hardware support from the linux-omap > >> >> tree. > >> >> > >> >> Much of this PM core code was written by Jouni Hogander with > >> >> significant contributions from Paul Walmsley as well as many others > >> >> from Nokia, Texas Instruments and linux-omap community. > >> > > >> > Overall comment, I think we need to rework the idle support code so > >> > that enable_hlt/disable_hlt can be used even when pm_idle has been > >> > overridden, rather than OMAP going off and inventing its own mechanisms. > >> > >> Would adding: > >> > >> if (hlt_counter) > >> cpu_relax(); > >> > >> to the beginning of omap*_pm_idle functions be sufficient? That will > >> at least allow the hlt stuff to behave as expected. > > > > Yes, but the comment was also directed at the other functions which > > increment/decrement that atomic_t variable to enable/disable sleep mode. > > > > Russell, > > Do you have a preference in how to export the hlt_counter to > platform-specific code? Sorry, I haven't had time to look at this, and the work I did to change the idle loop got lost when I last re-built my git tree. But... your patch isn't what I was meaning. I was meaning to avoid calling the idle function (_any_ idle function) if hlt_counter was non-zero. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
