Re: [PATCH] ARM: dts: omap3-beagle-xm: Add fixed 26MHz clock as fck for twl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 5, 2018 at 6:52 AM, Peter Ujfalusi <peter.ujfalusi@xxxxxx> wrote:
> The board uses 26MHz oscillator for the twl4030 HFCLK.
> This way we will not depend on the bootloader to configure the
> CFG_BOOT:HFCLK_FREQ
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> ---
> Hi,
>
> there might be other boards (all omap3 boards with twl4030?) which uses the same
> setup, but I only have schematics for beagle-xm.
>

I know I am late coming into this, but we have twl4030_omap3.dtsi for
the items common to omap3. Can we put the clock reference in that
file?

It seems like it would be cleaner than having a dozen boards or so
boards having the exact same copy of the same stuff. SHould something
change in the future, I would think it would make
maintenance easier too.  Just my two cents.

adam

> In order for the driver to actually use the clock the
> [PATCH] mfd: twl-core: Fix clock initialization
> need to be applied. W/o the twl-core patch the clock is just ignored.
>
> Regards,
> Peter
>
>  arch/arm/boot/dts/omap3-beagle-xm.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
> index 0349fcc9dc26..d80587de0bbf 100644
> --- a/arch/arm/boot/dts/omap3-beagle-xm.dts
> +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
> @@ -30,6 +30,13 @@
>                 ethernet = &ethernet;
>         };
>
> +       /* fixed 26MHz oscillator */
> +       hfclk_26m: oscillator {
> +               #clock-cells = <0>;
> +               compatible = "fixed-clock";
> +               clock-frequency = <26000000>;
> +       };
> +
>         leds {
>                 compatible = "gpio-leds";
>
> @@ -274,6 +281,9 @@
>                 interrupts = <7>; /* SYS_NIRQ cascaded to intc */
>                 interrupt-parent = <&intc>;
>
> +               clocks = <&hfclk_26m>;
> +               clock-names = "fck";
> +
>                 twl_audio: audio {
>                         compatible = "ti,twl4030-audio";
>                         codec {
> --
> Peter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux