Hi Mike, On Thu, May 14, 2009 at 4:20 PM, Mike Rapoport <mike@xxxxxxxxxxxxxx> wrote: > Hi Linus, > A few comments. > > Linus Walleij wrote: >> This adds a core driver for the AB3100 mixed-signal circuit >> found in the ST-Ericsson U300 series platforms. This driver >> is a singleton proxy for all accesses to the AB3100 >> sub-drivers which will be merged on top of this one, RTC, >> regulators, battery and system power control, vibrator, >> LEDs, and an ALSA codec. > > As general note on the driver, you export register access methods so they can be > called virtually anywhere. This will apply to existing manilined driver twl4030-core driver too. Adding David here. read/write register APIs for twl4030-core driver is also exported everywhere without per chip structure fed into it. ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html