> -----Original Message----- > From: Russell King - ARM Linux [mailto:linux@xxxxxxxxxxxxxxxx] > Sent: Monday, May 25, 2009 3:04 PM > To: Tony Lindgren > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxxxxx; > linux-omap@xxxxxxxxxxxxxxx; Shilimkar, Santosh > Subject: Re: [PATCH 07/10] ARM: OMAP2/3: sDMA: Correct > omap_request_dma_chain() > > On Tue, May 19, 2009 at 04:40:07PM -0700, Tony Lindgren wrote: > > From: Santosh Shilimkar <santosh.shilimkar@xxxxxx> > > > > Original OMAP DMA chaining design has chain_id as one of > the callback > > parameters. Patch 538528de0cb256f65716ab2e9613d9e920f97fe2 broke > > the desing. > > > > Change the callback to return the logical channel number and not > > chain_id. > > This patch does not make a material change. It merely > changes the name > used in a couple function pointer prototype. This has no > impact on the > generated code - iow, it's cosmetic. Yes it does look cosmetic but if you see the API signature, it corrects the callback parameters which actually the DMA lib sends. The current API signature is misleading for chained DMA transfers where the actual driver passes 'channel number' as one of the callback parameter instead of chain_id which was the original design. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
