* Tero Kristo <t-kristo@xxxxxx> [180228 05:38]: > On 27/02/18 18:48, Tony Lindgren wrote: > > * Tony Lindgren <tony@xxxxxxxxxxx> [180227 16:43]: > > > * Tero Kristo <t-kristo@xxxxxx> [180227 06:35]: > > > > On 27/02/18 00:05, Tony Lindgren wrote: > > > > > Hmm so should we have all the timers use bit 0 in the dtsi? > > > > > Or default to bit 24 for all of them? > > > > > > > > Who is going to control the clkctrl clock for the timers if you just control > > > > the opt clock? Also, ain't the bit 24 the clksel mux setting? Tweaking that > > > > would seem wrong... > > > > > > Yeah OK. > > > > $ git grep TIMER arch/arm/boot/dts/* | grep CLKCTRL > > > > And that shows timer1 using bit 24 for omap4, omap5 and dra7 > > dtsi files. > > > > So shouldn't that then be just bit 0 instead of bit 24 for > > those? And then we let omap_dm_timer_init_one() reparent it? > > Actually, that fck setting is because of this patch: > > 138f7ca78f5a0677f591fdf23d0309c2f4774bf7 > ARM: OMAP2+: timer: add support for fetching fck handle from DT > > So, you need to provide the clock handle at bit offset 24. > > The main clkctrl clock is still handled via hwmod core, or via the > interconnect driver. Yeah but in timer.c we just need to enable the module and it's clock and reparent if needed. There's nothing else to manage there, omap_dm_timer_init_one() just queries the rate. So I now think something is is wrong. For the interconnect target module we need to provide the module clock (bit 0) in the dts, not the source mux clock (bit 24). Then omap_dm_timer_init_one() can configure the source clock which is bit 24. My guess is that 138f7ca78f is really a workaround for set_parent() not working properly for clkctrl clock :) Then a board can specify it's desired source clock for system timer(s) by configure "assigned-lcok-parents" and set it to 32KiHz clock or SYS_CLK. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
