On Tue, May 12, 2009 at 6:11 PM, Santosh Shilimkar <santosh.shilimkar@xxxxxx> wrote: > > +#define OMAP_DMA4_CDP_REG(n) (0x60 * (n) + 0xd0) > +#define OMAP_DMA4_CNDP_REG(n) (0x60 * (n) + 0xd4) > +#define OMAP_DMA4_CCDN_REG(n) (0x60 * (n) + 0xd8) > + It would be consistent with all other definitions to *not* have the _REG suffix for these registers, don't you think ? Regards, Venkat. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html