On Thu, Nov 09, 2017 at 12:38:02PM +0200, Tero Kristo wrote: > Yeah, the DRA7 SoCs have 2x emif instances, and ECC is only available on one > (and it can be either enabled or disabled.) I thought it might be useful to > have the dimm info populated for both in this case to avoid confusion and to > be able to see the status from userspace. > > It is also possible to ditch that and only have dimm info for instances > which have ECC enabled. Which way would you prefer? Actually, having all DIMMs present, even if ECC is not enabled for a subset of them, would make the picture more user-friendly. Yap, that's better. > Thanks for review, and sorry again for missing the checkpatch. No worries, that's what review is for. :) -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html