On Tue, 2017-11-07 at 22:38 +0200, Tero Kristo wrote: > + if (edac_mc_add_mc(mci)) { > + pr_err("%s: Failed to register mci.\n", __func__); > + return -ENOMEM; This leaks the allocated mci structure in the error case. > + } > + > + /* add EMIF ECC error handler */ > + error_irq = platform_get_irq(pdev, 0); > + if (!error_irq) { > + dev_err(dev, "DDR3 EDAC irq number not defined\n"); > + return ret; This leaves the mc registered in the error case. Regards, Jan -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html