Hi, On 03/11/17 10:37, Ladislav Michl wrote: > On Fri, Nov 03, 2017 at 08:23:35AM +0100, Ladislav Michl wrote: >> Hi there, >> >> gpmc code checks for bank-width property which reassigns device_width >> previously setup in gpmc_read_settings_dt using 'gpmc,device-width' >> >> Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt >> does not mention 'bank-width' at all and 'gpmc,device-width' is marked >> as optional. >> >> gpmc_cs_program_settings bails out with -EINVAL when this property is >> not set. >> >> Is there something I'm missing (historical context) of following patch >> and fixing documentation is okay? > > I'm sorry, grep, my old friend for not using you more carefully. > > A couple of boards are using: > bank-width = <2>; > gpmc,device-width = <1>; > > eek? bank-width is required property in Documentation/devicetree/bindings/mtd/gpmc-nor.txt gpmc,device-width is required property in Documentation/devicetree/bindings/mtd/gpmc-onenand.txt nand-bus-width is optional property in Documentation/devicetree/bindings/mtd/gpmc-nand.txt We could make some improvements. e.g. - Make nand-bus-width, mandatory for gpmc-nand in Doc. - Make bank-width mandatory only for NOR in code. - Make gpmc,device-width mandatory for all devices except NOR and NAND. -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
