On Fri, Nov 03, 2017 at 08:23:35AM +0100, Ladislav Michl wrote:
> Hi there,
>
> gpmc code checks for bank-width property which reassigns device_width
> previously setup in gpmc_read_settings_dt using 'gpmc,device-width'
>
> Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt
> does not mention 'bank-width' at all and 'gpmc,device-width' is marked
> as optional.
>
> gpmc_cs_program_settings bails out with -EINVAL when this property is
> not set.
>
> Is there something I'm missing (historical context) of following patch
> and fixing documentation is okay?
I'm sorry, grep, my old friend for not using you more carefully.
A couple of boards are using:
bank-width = <2>;
gpmc,device-width = <1>;
eek?
> ladis
>
> 8<-----------------------
> Subject: [PATCH] memory: omap-gpmc: Remove bank-width DT property
>
> 'bank-width' is undocumented and unneeded as value of device_width is
> previously read from documented 'gpmc,device-width' property.
>
> Signed-off-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx>
> ---
> drivers/memory/omap-gpmc.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 24b584b74d84..9322ff1791df 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2151,14 +2151,6 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
> /* disable write protect */
> gpmc_configure(GPMC_CONFIG_WP, 0);
> gpmc_s.device_nand = true;
> - } else {
> - ret = of_property_read_u32(child, "bank-width",
> - &gpmc_s.device_width);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "%pOF has no 'bank-width' property\n",
> - child);
> - goto err;
> - }
> }
>
> /* Reserve wait pin if it is required and valid */
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
