[bug report] ARM: OMAP2+: Populate legacy resources for dma and smartreflex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Tony Lindgren,

This is a semi-automatic email about new static checker warnings.

The patch d85a2d61432a: "ARM: OMAP2+: Populate legacy resources for 
dma and smartreflex" from Oct 10, 2017, leads to the following Smatch 
complaint:

arch/arm/mach-omap2/omap_device.c:453 omap_device_copy_resources()
	 error: we previously assumed 'oh' could be null (see line 394)

arch/arm/mach-omap2/omap_device.c
   393	
   394		if (!oh || !oh->od || !oh->od->pdev) {
                    ^^^
Patch adds check for NULL.

   395			error = -EINVAL;
   396			goto error;
   397		}
   398	

[ snip ]

   448	
   449	free:
   450		kfree(res);
   451	
   452	error:
   453		WARN(error, "%s: %s device %s failed: %i\n",
   454		     __func__, oh->name, dev_name(&pdev->dev),
                               ^^^^^^^^
and the patch adds a dereference.

   455		     error);

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux