Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 2017-08-17 10:01, Alexander Smirnov wrote:
> Added driver author to Cc.
>
> On 08/13/2017 08:57 PM, Alexander Smirnov wrote:
>> DMA crossbar uses 'xbar->dma_inuse' variable to manage allocated routes.
>> Each bit represents respective DMA channel. If the channel is free, bit
>> is set to '0', if channel is allocated, bit should be set to '1'.
>>
>> In reserve function, the bits for requested DMA channels are cleared, so
>> they are not really reserved, but freed and become ready for allocation.
Hah, I could not believe I did that ;) Thanks for catching it!!!
Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
>>
>> Signed-off-by: Alexander Smirnov <asmirnov@xxxxxxxxx>
>> ---
>> drivers/dma/ti-dma-crossbar.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/ti-dma-crossbar.c
>> b/drivers/dma/ti-dma-crossbar.c
>> index e107779..404cdb8 100644
>> --- a/drivers/dma/ti-dma-crossbar.c
>> +++ b/drivers/dma/ti-dma-crossbar.c
>> @@ -299,7 +299,7 @@ static const struct of_device_id
>> ti_dra7_master_match[] = {
>> static inline void ti_dra7_xbar_reserve(int offset, int len,
>> unsigned long *p)
>> {
>> for (; len > 0; len--)
>> - clear_bit(offset + (len - 1), p);
>> + set_bit(offset + (len - 1), p);
>> }
>> static int ti_dra7_xbar_probe(struct platform_device *pdev)
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
