On Sun, Aug 6, 2017 at 9:57 PM, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Sun, Aug 6, 2017 at 6:14 PM, Sergei Shtylyov > <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: >> Hello! >> >> Here's the set of 2 patches against the 'omap-for-v4.13/fixes' branch of Tony >> Lingren's 'linux-omap.git' repo. I'm fixing of_irq_get() DT API result >> checks. >> >> [1/2] ARM: OMAP3+: PRM: fix of_irq_get() result check >> [2/2] ARM: OMAP4+: PRM: fix of_irq_get() result checks > > What IRQ domain did you consider? In case of STRICT the mapping will > be 1:1 and 0 is _valid_ IRQ number for hwirq. > 0 in Linux kernel IRQ numbering often means NO_IRQ. But there might be > exceptions. > > So, it would be nice to see if there is a problem on certain platform > if the patch is not applied, or is it problem on OF IRQ code, or > wrong interpratation of 0? Okay, I have looked into OF code and it seems always allocating descriptors where numbering starts from 1 (see hint variable deep in the code). This series is a good fix. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
