* Tony Lindgren <tony@xxxxxxxxxxx> [170725 08:04]:
>
> Default is status = "okay" and there really should be no reason to mark SoC
> devices as "disabled" unless they really are not accessible as on HS devices.
> We do have PM working for many omap3 devices without having to use status =
> "disabled" at all except for some HS devices. Of course this needs to be
> verified though :)
>
> But really, "disabled" is not the problem for PM, the limitations we have
> for PM issues are missing runtime PM implementations in device drivers,
> such as for OHCI/EHCI.
And to verify this, I stripped out whatever status = "disabled" omap3.dtsi
has, applied the $subject patch, compiled v4.13-rc2 with omap2plus_defconfig,
booted torpedo over NFSroot, enabled idle, and it is hitting off mode during
idle just fine. Similar test needs to be done on n900 for example, my test
patch below for reference.
Whereever this non-standard requirement for tagging unused SoC devices
"disabled" crept in, it's not clearly what the mainline Linux kernel does.
Regards,
Tony
8< ----------------
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -474,7 +474,6 @@
reg = <0x5d000000 0x80>;
interrupts = <28>;
ti,hwmods = "mmu_iva";
- status = "disabled";
};
wdt2: wdt@48314000 {
@@ -498,7 +497,6 @@
dma-names = "tx", "rx";
clocks = <&mcbsp1_fck>;
clock-names = "fck";
- status = "disabled";
};
mcbsp2: mcbsp@49022000 {
@@ -518,7 +516,6 @@
dma-names = "tx", "rx";
clocks = <&mcbsp2_fck>, <&mcbsp2_ick>;
clock-names = "fck", "ick";
- status = "disabled";
};
mcbsp3: mcbsp@49024000 {
@@ -538,7 +535,6 @@
dma-names = "tx", "rx";
clocks = <&mcbsp3_fck>, <&mcbsp3_ick>;
clock-names = "fck", "ick";
- status = "disabled";
};
mcbsp4: mcbsp@49026000 {
@@ -556,7 +552,6 @@
dma-names = "tx", "rx";
clocks = <&mcbsp4_fck>;
clock-names = "fck";
- status = "disabled";
};
mcbsp5: mcbsp@48096000 {
@@ -574,7 +569,6 @@
dma-names = "tx", "rx";
clocks = <&mcbsp5_fck>;
clock-names = "fck";
- status = "disabled";
};
sham: sham@480c3000 {
@@ -757,7 +751,6 @@
dss: dss@48050000 {
compatible = "ti,omap3-dss";
reg = <0x48050000 0x200>;
- status = "disabled";
ti,hwmods = "dss_core";
clocks = <&dss1_alwon_fck>;
clock-names = "fck";
@@ -781,7 +774,6 @@
<0x4804ff00 0x20>;
reg-names = "proto", "phy", "pll";
interrupts = <25>;
- status = "disabled";
ti,hwmods = "dss_dsi1";
clocks = <&dss1_alwon_fck>, <&dss2_alwon_fck>;
clock-names = "fck", "sys_clk";
@@ -790,7 +782,6 @@
rfbi: encoder@48050800 {
compatible = "ti,omap3-rfbi";
reg = <0x48050800 0x100>;
- status = "disabled";
ti,hwmods = "dss_rfbi";
clocks = <&dss1_alwon_fck>, <&dss_ick>;
clock-names = "fck", "ick";
@@ -799,7 +790,6 @@
venc: encoder@48050c00 {
compatible = "ti,omap3-venc";
reg = <0x48050c00 0x100>;
- status = "disabled";
ti,hwmods = "dss_venc";
clocks = <&dss_tv_fck>;
clock-names = "fck";
@@ -810,8 +800,6 @@
compatible = "ti,omap3-ssi";
ti,hwmods = "ssi";
- status = "disabled";
-
reg = <0x48058000 0x1000>,
<0x48059000 0x1000>;
reg-names = "sys",
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
