8250_omap: RS485 enabling ioctl not working the second time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

There is an issue in v4.9 that I already found on v4.6-4.8 (and submitted to linux-serial but no one answered there).

The first time you open the serial port yo can enable rs485 through an ioctl call and everything works as expected, but if you close the serial port and then reopen the ioctl call to enable rs485 is ignored. 

What happens is that the second time the ioctl is issued the "omap_8250_rs485_config" function (8250_omap.c) calls "serial8250_em485_init" (8250_port.c) with a null "p->em485" pointer so the ioctl call has no effect.

If rs485 is manually disabled through an ioctl before closing the serial port this doesn't happen; everything works as it should.

I already posted a dirty fix against 4.6 for clarification purposes, but I don't know enough to make patches without guidance.

https://www.spinics.net/lists/linux-serial/msg24061.html

Is this a known bug? How should I proceed to fix this?




--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux