Hi,
On Mon, Jul 10, 2017 at 01:23:45PM +0100, Mark Brown wrote:
> On Fri, Jul 07, 2017 at 10:08:12PM +0200, Sebastian Reichel wrote:
>
> > While working on the audio-codec I noticed, that the
> > low power mode of the regulators are not properly
> > supported. This fixes the issue for vaudio.
>
> In what way is it not properly supported and how does this change ensure
> that it is properly supported?
>
> > +static unsigned int cpcap_map_mode(unsigned int mode)
> > +{
> > + switch (mode) {
> > + case CPCAP_BIT_AUDIO_LOW_PWR:
> > + return REGULATOR_MODE_STANDBY;
> > + default:
> > + return REGULATOR_MODE_NORMAL;
> > + }
> > +}
>
> This function is being added but is never referenced AFAICT, it should
> either be removed or used.
You probably skipped over the patch to fast, it is referenced in the
patch section before the one adding the function:
+ .of_map_mode = cpcap_map_mode, \
> If it is being used it should be changed so that it doesn't accept
> the default case but instead accepts only specific values so that
> the mapping of modes to regulator modes stays 1:1, unknown modes
> should error out.
Fair point.
-- Sebastian
Attachment:
signature.asc
Description: PGP signature
