On 07/03/2017 11:58 AM, Johan Hovold wrote: > On Fri, May 19, 2017 at 03:04:38PM -0500, Dave Gerlach wrote: >> Add amx3_common_pm_init to create a dummy platform_device for >> pm33xx so that our pm33xx module can probe and am335x and am437x >> platforms to enable basic suspend to mem and standby support. >> >> Signed-off-by: Dave Gerlach <d-gerlach@xxxxxx> >> --- > >> +void __init amx3_common_pm_init(void) >> +{ >> + struct platform_device_info devinfo = { }; > > You should make sure devinfo is zeroed, and also set .id to -1. Thanks for the comment, will look into updating this for next version. Regards, Dave > >> + struct am33xx_pm_platform_data *pdata; >> + >> + pdata = am33xx_pm_get_pdata(); >> + devinfo.name = "pm33xx"; >> + devinfo.data = pdata; >> + devinfo.size_data = sizeof(*pdata); >> + platform_device_register_full(&devinfo); >> +} > > Johan > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html