Hi, On Sat, Mar 04, 2017 at 08:26:55AM -0800, Tony Lindgren wrote: > * Tony Lindgren <tony@xxxxxxxxxxx> [170303 08:31]: > > * Sebastian Reichel <sre@xxxxxxxxxx> [170303 03:03]: > > > On Wed, Mar 01, 2017 at 05:49:11PM -0800, Tony Lindgren wrote: > > > > Some of the command mode LCD patches could be sent out too, and > > > > if the timing patch is OK then we can configure the LCD in the dts > > > > too. Have you had a chance to look at those related to what all I > > > > broke for n950? > > > > > > I took your patchset and fixed it for N950. The main problem was, > > > that you dropped the fifo size update, which is required for OMAP3 > > > (HW bug). Here is a branch based on recent master branch from > > > torvalds. I had a quick test with droid4 and dmesg still looked fine, > > > but I did not have the lm3532 patches in that branch and nothing is > > > visible without display backlight. Can you check if the branch works > > > for you on D4? > > > > OK good to hear you figured it out. Yeah I tried to cut down the > > changes to minimum to get some idea what's going on and noticed I did > > not need the fifo changes for droid 4. I'll take a look later on today > > or over the weekend. > > I tested your branch and those patches work just fine on droid 4. > > I did not test the fifo patch as it's missing something compiles > as loadable modules: > > ERROR: "dispc_ovl_set_fifo_threshold" [drivers/gpu/drm/omapdrm/omapdrm.ko] undefined! > ERROR: "dispc_ovl_compute_fifo_thresholds" [drivers/gpu/drm/omapdrm/omapdrm.ko] undefined! > > Probably just EXPORT_SYMBOL missing? Yes, I didn't notice, since I test stuff with monolithic kernel. kbuild test robot already noticed missing EXPORT_SYMBOL before you, though and I rebased the branch (obviously after you already pulled it). > Anyways, yeah I guess that set is pretty much ready to be sent for > review if you feel like sending it. Or let me know if you want me to > send it. Ok. It's just being sent out. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
