Re: [PATCH 2/4] ARM: OMAP2+: gpmc-nand: fix error unwinding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Roger,

On Tue, Feb 14, 2017 at 12:02:19PM +0200, Roger Quadros wrote:
> Hi,
> 
> On 11/02/17 15:02, Ladislav Michl wrote:
> > Do not call platform_device_put if platform_device_alloc
> > failed to allocate.
> > 
> 
> It doesn't matter if platform_device_put is called if
> platform_device_alloc fails as it checks for NULL pdev internally.
> 
> Did you face any issues without this patch?

No, it just makes things to look more likely an error unwinding pattern
which is IMHO easier to read. I'm not pushing to include this patch as
I made it while looking for differences between probing NAND and OneNAND.

Best reards,
	ladis
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux